iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: goldfish: goldfish_nand: Return correct error code

Browse Source 
The return value of devm_kzalloc on failure of allocation of memory should
be -ENOMEM and not -1.

Found using Coccinelle. A simplified version of the semantic patch
used is:

//<smpl>
@@
expression *e;
@@

e = devm_kzalloc(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//</smpl>

The single call site does not perform any checks on the return value, hence
no change is required at the call site.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Amitoj Kaur Chawla 2016-02-12 14:09:49 +05:30 committed by Greg Kroah-Hartman
parent c272dc2da1
commit 814625b539
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/goldfish/goldfish_nand.c
View File

@ -290,7 +290,7 @@ static int nand_setup_cmd_params(struct platform_device *pdev,
nand->cmd_params = devm_kzalloc(&pdev->dev, nand->cmd_params = devm_kzalloc(&pdev->dev,
sizeof(struct cmd_params), GFP_KERNEL); sizeof(struct cmd_params), GFP_KERNEL);
if (!nand->cmd_params) if (!nand->cmd_params)
return -1; return -ENOMEM;
paddr = __pa(nand->cmd_params); paddr = __pa(nand->cmd_params);
writel((u32)(paddr >> 32), base + NAND_CMD_PARAMS_ADDR_HIGH); writel((u32)(paddr >> 32), base + NAND_CMD_PARAMS_ADDR_HIGH);