iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: qla2xxx: Suppress gcc 7 fall-through warnings

Browse Source 
Avoid that building with gcc 7 and W=1 triggers warnings similar to the
following:

drivers/scsi/qla2xxx/qla_isr.c:1189:27: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: Quinn Tran <quinn.tran@cavium.com>
Cc: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche 2017-12-07 16:02:46 -08:00 committed by Martin K. Petersen
parent f280c77dc9
commit 81881861ae
4 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/scsi/qla2xxx/qla_gs.c
View File

@ -177,7 +177,7 @@ qla2x00_chk_ms_status(scsi_qla_host_t *vha, ms_iocb_entry_t *ms_pkt,
break; break;
case CS_TIMEOUT: case CS_TIMEOUT:
rval = QLA_FUNCTION_TIMEOUT; rval = QLA_FUNCTION_TIMEOUT;
/* drop through */ /* fall through */
default: default:
ql_dbg(ql_dbg_disc, vha, 0x2033, ql_dbg(ql_dbg_disc, vha, 0x2033,
"%s failed, completion status (%x) on port_id: " "%s failed, completion status (%x) on port_id: "

5
drivers/scsi/qla2xxx/qla_isr.c
View File

@ -1202,6 +1202,7 @@ global_port_update:
qla2xxx_wake_dpc(vha); qla2xxx_wake_dpc(vha);
} }
} }
/* fall through */
case MBA_IDC_COMPLETE: case MBA_IDC_COMPLETE:
if (ha->notify_lb_portup_comp && !vha->vp_idx) if (ha->notify_lb_portup_comp && !vha->vp_idx)
complete(&ha->lb_portup_comp); complete(&ha->lb_portup_comp);
@ -1769,7 +1770,7 @@ qla24xx_logio_entry(scsi_qla_host_t *vha, struct req_que *req,
set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags); set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags);
qla2xxx_wake_dpc(vha); qla2xxx_wake_dpc(vha);
} }
/* drop through */ /* fall through */
default: default:
data[0] = MBS_COMMAND_ERROR; data[0] = MBS_COMMAND_ERROR;
break; break;
@ -2967,9 +2968,9 @@ process_err:
(response_t *)pkt); (response_t *)pkt);
break; break;
} else { } else {
/* drop through */
qlt_24xx_process_atio_queue(vha, 1); qlt_24xx_process_atio_queue(vha, 1);
} }
/* fall through */
case ABTS_RESP_24XX: case ABTS_RESP_24XX:
case CTIO_TYPE7: case CTIO_TYPE7:
case CTIO_CRC2: case CTIO_CRC2:

1
drivers/scsi/qla2xxx/qla_sup.c
View File

@ -2461,6 +2461,7 @@ qla2x00_write_optrom_data(struct scsi_qla_host *vha, uint8_t *buf,
sec_mask = 0x1e000; sec_mask = 0x1e000;
break; break;
} }
/* fall through */
default: default:
/* Default to 16 kb sector size. */ /* Default to 16 kb sector size. */
rest_addr = 0x3fff; rest_addr = 0x3fff;

3
drivers/scsi/qla2xxx/qla_target.c
View File

@ -450,6 +450,7 @@ void qlt_response_pkt_all_vps(struct scsi_qla_host *vha,
ql_dbg(ql_dbg_tgt, vha, 0xe073, ql_dbg(ql_dbg_tgt, vha, 0xe073,
"qla_target(%d):%s: CRC2 Response pkt\n", "qla_target(%d):%s: CRC2 Response pkt\n",
vha->vp_idx, __func__); vha->vp_idx, __func__);
/* fall through */
case CTIO_TYPE7: case CTIO_TYPE7:
{ {
struct ctio7_from_24xx *entry = (struct ctio7_from_24xx *)pkt; struct ctio7_from_24xx *entry = (struct ctio7_from_24xx *)pkt;
@ -4889,7 +4890,7 @@ static int qlt_24xx_handle_els(struct scsi_qla_host *vha,
res = 1; res = 1;
break; break;
} }
/* drop through */ /* fall through */
case ELS_LOGO: case ELS_LOGO:
case ELS_PRLO: case ELS_PRLO:
spin_lock_irqsave(&ha->tgt.sess_lock, flags); spin_lock_irqsave(&ha->tgt.sess_lock, flags);