iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/amdgpu: fix retry loop test

Browse Source 
This loop will exit with "retry" set to -1 if it fails but the code
checks for if "retry" is zero.  Fix this by changing post-op to a
pre-op.  --retry vs retry--.

Fixes: e01eeffc3f86 ("drm/amd/pm: avoid driver getting empty metrics table for the first time")
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Dan Carpenter 2023-09-06 13:54:38 +03:00 committed by Alex Deucher
parent 679fc891bf
commit 81cc8779cf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
View File

@ -336,7 +336,7 @@ static int smu_v13_0_6_setup_driver_pptable(struct smu_context *smu)
/* Store one-time values in driver PPTable */ /* Store one-time values in driver PPTable */
if (!pptable->Init) { if (!pptable->Init) {
while (retry--) { while (--retry) {
ret = smu_v13_0_6_get_metrics_table(smu, NULL, true); ret = smu_v13_0_6_get_metrics_table(smu, NULL, true);
if (ret) if (ret)
return ret; return ret;