iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm/hugetlb: Use try_grab_folio() instead of try_grab_compound_head()

Browse Source 
follow_hugetlb_page() only cares about success or failure, so it doesn't
need to know the type of the returned pointer, only whether it's NULL
or not.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
This commit is contained in:
Matthew Wilcox (Oracle) 2022-01-08 00:15:04 -05:00
parent d8ddc099c6
commit 822951d846
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/linux/mm.h
View File

@ -1124,9 +1124,6 @@ static inline void get_page(struct page *page)
} }
bool __must_check try_grab_page(struct page *page, unsigned int flags); bool __must_check try_grab_page(struct page *page, unsigned int flags);
struct page *try_grab_compound_head(struct page *page, int refs,
unsigned int flags);
static inline __must_check bool try_get_page(struct page *page) static inline __must_check bool try_get_page(struct page *page)
{ {

2
mm/gup.c
View File

@ -133,7 +133,7 @@ struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags)
return NULL; return NULL;
} }
struct page *try_grab_compound_head(struct page *page, static inline struct page *try_grab_compound_head(struct page *page,
int refs, unsigned int flags) int refs, unsigned int flags)
{ {
return &try_grab_folio(page, refs, flags)->page; return &try_grab_folio(page, refs, flags)->page;

5
mm/hugetlb.c
View File

@ -6076,7 +6076,7 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
if (pages) { if (pages) {
/* /*
* try_grab_compound_head() should always succeed here, * try_grab_folio() should always succeed here,
* because: a) we hold the ptl lock, and b) we've just * because: a) we hold the ptl lock, and b) we've just
* checked that the huge page is present in the page * checked that the huge page is present in the page
* tables. If the huge page is present, then the tail * tables. If the huge page is present, then the tail
@ -6085,8 +6085,7 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
* any way. So this page must be available at this * any way. So this page must be available at this
* point, unless the page refcount overflowed: * point, unless the page refcount overflowed:
*/ */
if (WARN_ON_ONCE(!try_grab_compound_head(pages[i], if (WARN_ON_ONCE(!try_grab_folio(pages[i], refs,
refs,
flags))) { flags))) {
spin_unlock(ptl); spin_unlock(ptl);
remainder = 0; remainder = 0;