iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NFSD: Clean up nfsd4_encode_open()

Browse Source 
Finish cleaning up nfsd4_encode_open().

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This commit is contained in:
Chuck Lever 2023-09-29 09:59:31 -04:00
parent 802e191353
commit 841735b3fd
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
fs/nfsd/nfs4xdr.c
View File

@ -4212,20 +4212,23 @@ nfsd4_encode_open(struct nfsd4_compoundres *resp, __be32 nfserr,
struct nfsd4_open *open = &u->open;
struct xdr_stream *xdr = resp->xdr;
/* stateid */
nfserr = nfsd4_encode_stateid4(xdr, &open->op_stateid);
if (nfserr)
if (nfserr != nfs_ok)
return nfserr;
/* cinfo */
nfserr = nfsd4_encode_change_info4(xdr, &open->op_cinfo);
if (nfserr)
if (nfserr != nfs_ok)
return nfserr;
if (xdr_stream_encode_u32(xdr, open->op_rflags) < 0)
return nfserr_resource;
/* rflags */
nfserr = nfsd4_encode_uint32_t(xdr, open->op_rflags);
if (nfserr != nfs_ok)
return nfserr;
/* attrset */
nfserr = nfsd4_encode_bitmap4(xdr, open->op_bmval[0],
open->op_bmval[1], open->op_bmval[2]);
if (nfserr)
if (nfserr != nfs_ok)
return nfserr;
/* delegation */
return nfsd4_encode_open_delegation4(xdr, open);
}