iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

jz4740-battery: Check if platform_data is supplied

Browse Source 
Currently platform_data is dereferenced without checking whether it
is actually set, which can lead to kernel crashes.
This patch adds a check which will abort the drivers probe function
gracefully if no platform_data is supplied.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
This commit is contained in:
Lars-Peter Clausen 2010-11-11 19:00:53 +01:00 committed by Anton Vorontsov
parent e1a85694e0
commit 8477cedb49
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/power/jz4740-battery.c
View File

@ -246,6 +246,11 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
struct jz_battery *jz_battery; struct jz_battery *jz_battery;
struct power_supply *battery; struct power_supply *battery;
if (!pdata) {
dev_err(&pdev->dev, "No platform_data supplied\n");
return -ENXIO;
}
jz_battery = kzalloc(sizeof(*jz_battery), GFP_KERNEL); jz_battery = kzalloc(sizeof(*jz_battery), GFP_KERNEL);
if (!jz_battery) { if (!jz_battery) {
dev_err(&pdev->dev, "Failed to allocate driver structure\n"); dev_err(&pdev->dev, "Failed to allocate driver structure\n");