iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: gemini: Fix missing clk_disable_unprepare() in error path of gemini_ethernet_port_probe()

Browse Source 
Fix the missing clk_disable_unprepare() before return
from gemini_ethernet_port_probe() in the error handling case.

Fixes: 4d5ae32f5e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wang Hai 2020-07-30 15:30:00 +08:00 committed by David S. Miller
parent 59929fbb45
commit 85496a2922
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/cortina/gemini.c
View File

@ -2446,6 +2446,7 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
port->reset = devm_reset_control_get_exclusive(dev, NULL); port->reset = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(port->reset)) { if (IS_ERR(port->reset)) {
dev_err(dev, "no reset\n"); dev_err(dev, "no reset\n");
clk_disable_unprepare(port->pclk);
return PTR_ERR(port->reset); return PTR_ERR(port->reset);
} }
reset_control_reset(port->reset); reset_control_reset(port->reset);
@ -2501,8 +2502,10 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
IRQF_SHARED, IRQF_SHARED,
port_names[port->id], port_names[port->id],
port); port);
if (ret) if (ret) {
clk_disable_unprepare(port->pclk);
return ret; return ret;
}
ret = register_netdev(netdev); ret = register_netdev(netdev);
if (!ret) { if (!ret) {