iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/panel: rpi-touchscreen: propagate errors in rpi_touchscreen_i2c_read()

Browse Source 
There is one caller which checks whether rpi_touchscreen_i2c_read()
returns negative error codes.  Currently it can't because negative
error codes are truncated to u8, but that's easy to fix if we change the
type to int.

Fixes: 2f733d6194 ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20171020002845.kar2wg7gqxg7tzqi@mwanda
Reviewed-by: Eric Anholt <eric@anholt.net>
This commit is contained in:
Dan Carpenter 2017-10-20 03:28:45 +03:00 committed by Eric Anholt
parent 33b54ea110
commit 85b4587f8e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
View File

@ -221,7 +221,7 @@ static struct rpi_touchscreen *panel_to_ts(struct drm_panel *panel)
return container_of(panel, struct rpi_touchscreen, base); return container_of(panel, struct rpi_touchscreen, base);
} }
static u8 rpi_touchscreen_i2c_read(struct rpi_touchscreen *ts, u8 reg) static int rpi_touchscreen_i2c_read(struct rpi_touchscreen *ts, u8 reg)
{ {
return i2c_smbus_read_byte_data(ts->i2c, reg); return i2c_smbus_read_byte_data(ts->i2c, reg);
} }