iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ext4: do not try to grab the s_umount semaphore in ext4_quota_off

Browse Source 
It's not needed to sync the filesystem, and it fixes a lock_dep complaint.

Signed-off-by: Dmitry Monakhov <dmonakhov@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Dmitry Monakhov 2010-11-08 13:47:33 -05:00 committed by Theodore Ts'o
parent 83668e7141
commit 87009d86dc
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/ext4/super.c
View File

@ -4570,12 +4570,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
static int ext4_quota_off(struct super_block *sb, int type) static int ext4_quota_off(struct super_block *sb, int type)
{ {
/* Force all delayed allocation blocks to be allocated */ /* Force all delayed allocation blocks to be allocated.
if (test_opt(sb, DELALLOC)) { * Caller already holds s_umount sem */
down_read(&sb->s_umount); if (test_opt(sb, DELALLOC))
sync_filesystem(sb); sync_filesystem(sb);
up_read(&sb->s_umount);
}
return dquot_quota_off(sb, type); return dquot_quota_off(sb, type);
} }