iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mtd: gpmi: use devm_ioremap_resource

Browse Source 
Use the devm_ioremap_resource to simplify the code.

[Note: as a side effect, this adds a missing call to request_memory().]

Signed-off-by: Huang Shijie <b32955@freescale.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
This commit is contained in:
Huang Shijie 2013-11-14 14:25:48 +08:00 committed by Brian Norris
parent ccce417734
commit 87a9d69892
1 changed files with 3 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/mtd/nand/gpmi-nand/gpmi-nand.c
View File

@ -486,16 +486,9 @@ static int acquire_register_block(struct gpmi_nand_data *this,
void __iomem *p; void __iomem *p;
r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res_name); r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res_name);
if (!r) { p = devm_ioremap_resource(&pdev->dev, r);
pr_err("Can't get resource for %s\n", res_name); if (IS_ERR(p))
return -ENODEV; return PTR_ERR(p);
}
p = ioremap(r->start, resource_size(r));
if (!p) {
pr_err("Can't remap %s\n", res_name);
return -ENOMEM;
}
if (!strcmp(res_name, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME)) if (!strcmp(res_name, GPMI_NAND_GPMI_REGS_ADDR_RES_NAME))
res->gpmi_regs = p; res->gpmi_regs = p;
@ -507,17 +500,6 @@ static int acquire_register_block(struct gpmi_nand_data *this,
return 0; return 0;
} }
static void release_register_block(struct gpmi_nand_data *this)
{
struct resources *res = &this->resources;
if (res->gpmi_regs)
iounmap(res->gpmi_regs);
if (res->bch_regs)
iounmap(res->bch_regs);
res->gpmi_regs = NULL;
res->bch_regs = NULL;
}
static int acquire_bch_irq(struct gpmi_nand_data *this, irq_handler_t irq_h) static int acquire_bch_irq(struct gpmi_nand_data *this, irq_handler_t irq_h)
{ {
struct platform_device *pdev = this->pdev; struct platform_device *pdev = this->pdev;
@ -665,13 +647,11 @@ exit_clock:
exit_dma_channels: exit_dma_channels:
release_bch_irq(this); release_bch_irq(this);
exit_regs: exit_regs:
release_register_block(this);
return ret; return ret;
} }
static void release_resources(struct gpmi_nand_data *this) static void release_resources(struct gpmi_nand_data *this)
{ {
release_register_block(this);
release_bch_irq(this); release_bch_irq(this);
release_dma_channels(this); release_dma_channels(this);
} }