iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: usb-audio: fix comment reference in __uac_clock_find_source

Browse Source 
snd_usb_find_clock_source and snd_usb_find_clock_selector are helper
macros that look at an entity id and validate that this entity id is
in fact a clock source or a clock selector. The present comments
inside __uac_clock_find_source give the reader the impression we're
looking for an entity id.

We're looking for an entity id indeed, the clock source, but since
__uac_clock_find_source is recursive, we're also looking *at* the
entity ids, in the search for the one clock source.

Fix the comment so we don't give readers a wrong idea.

Signed-off-by: Geraldo Nascimento <geraldogabriel@gmail.com>
Link: https://lore.kernel.org/r/YU6Kj05oOqRmhJDf@geday
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Geraldo Nascimento 2021-09-24 23:33:51 -03:00 committed by Takashi Iwai
parent f02f2f1bf9
commit 882e013a32
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sound/usb/clock.c
View File

@ -271,7 +271,7 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip,
return -EINVAL; return -EINVAL;
} }
/* first, see if the ID we're looking for is a clock source already */ /* first, see if the ID we're looking at is a clock source already */
source = snd_usb_find_clock_source(chip, entity_id, proto); source = snd_usb_find_clock_source(chip, entity_id, proto);
if (source) { if (source) {
entity_id = GET_VAL(source, proto, bClockID); entity_id = GET_VAL(source, proto, bClockID);
@ -297,7 +297,7 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip,
goto find_source; goto find_source;
} }
/* the entity ID we are looking for is a selector. /* the entity ID we are looking at is a selector.
* find out what it currently selects */ * find out what it currently selects */
ret = uac_clock_selector_get_val(chip, clock_id); ret = uac_clock_selector_get_val(chip, clock_id);
if (ret < 0) { if (ret < 0) {