From 884054403393a46ae88f24b0d76581278222f5ce Mon Sep 17 00:00:00 2001 From: Venkata Sandeep Dhanalakota Date: Mon, 16 Dec 2019 10:53:32 -0800 Subject: [PATCH] drm/i915: Fix typecheck macro in GT_TRACE typecheck() macro creates an huge stack size causing issues with static analysis with coverity, addressing this with creating a local pointer. Fixes: 639f2f24895f ("drm/i915: Introduce new macros for tracing") Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Daniel Vetter Cc: Chris Wilson Cc: Jani Nikula Signed-off-by: Venkata Sandeep Dhanalakota Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191216185332.83289-1-venkata.s.dhanalakota@intel.com --- drivers/gpu/drm/i915/gt/intel_gt.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h index 9d9e8831daeb..2355cf129e9c 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.h +++ b/drivers/gpu/drm/i915/gt/intel_gt.h @@ -12,9 +12,9 @@ struct drm_i915_private; -#define GT_TRACE(gt__, fmt, ...) do { \ - typecheck(struct intel_gt, *(gt__)); \ - GEM_TRACE("%s " fmt, dev_name(gt->i915->drm.dev), \ +#define GT_TRACE(gt, fmt, ...) do { \ + const struct intel_gt *gt__ __maybe_unused = (gt); \ + GEM_TRACE("%s " fmt, dev_name(gt__->i915->drm.dev), \ ##__VA_ARGS__); \ } while (0)