iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bcachefs: Improve fs_usage_apply_warn() message

Browse Source 
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
This commit is contained in:
Kent Overstreet
2022-10-24 13:34:17 -04:00
parent 80fe580c8d
commit 8852501fe5
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
fs/bcachefs/buckets.c
View File

@@ -1276,23 +1276,24 @@ void fs_usage_apply_warn(struct btree_trans *trans,
struct btree_insert_entry *i; struct btree_insert_entry *i;
struct printbuf buf = PRINTBUF; struct printbuf buf = PRINTBUF;
bch_err(c, "disk usage increased %lli more than %u sectors reserved", prt_printf(&buf,
should_not_have_added, disk_res_sectors); bch2_fmt(c, "disk usage increased %lli more than %u sectors reserved)"),
should_not_have_added, disk_res_sectors);
trans_for_each_update(trans, i) { trans_for_each_update(trans, i) {
struct bkey_s_c old = { &i->old_k, i->old_v }; struct bkey_s_c old = { &i->old_k, i->old_v };
pr_err("while inserting"); prt_str(&buf, "new ");
printbuf_reset(&buf);
bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(i->k)); bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(i->k));
pr_err(" %s", buf.buf); prt_newline(&buf);
pr_err("overlapping with");
printbuf_reset(&buf); prt_str(&buf, "old ");
bch2_bkey_val_to_text(&buf, c, old); bch2_bkey_val_to_text(&buf, c, old);
pr_err(" %s", buf.buf); prt_newline(&buf);
} }
__WARN(); __WARN();
bch2_print_string_as_lines(KERN_ERR, buf.buf);
printbuf_exit(&buf); printbuf_exit(&buf);
} }