net, xfrm: convert xfrm_state.refcnt from atomic_t to refcount_t
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: David Windsor <dwindsor@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
5534a51ab7
commit
88755e9c7c
@ -48,7 +48,7 @@ static HLIST_HEAD(xfrm_state_gc_list);
|
||||
|
||||
static inline bool xfrm_state_hold_rcu(struct xfrm_state __rcu *x)
|
||||
{
|
||||
return atomic_inc_not_zero(&x->refcnt);
|
||||
return refcount_inc_not_zero(&x->refcnt);
|
||||
}
|
||||
|
||||
static inline unsigned int xfrm_dst_hash(struct net *net,
|
||||
@ -558,7 +558,7 @@ struct xfrm_state *xfrm_state_alloc(struct net *net)
|
||||
|
||||
if (x) {
|
||||
write_pnet(&x->xs_net, net);
|
||||
atomic_set(&x->refcnt, 1);
|
||||
refcount_set(&x->refcnt, 1);
|
||||
atomic_set(&x->tunnel_users, 0);
|
||||
INIT_LIST_HEAD(&x->km.all);
|
||||
INIT_HLIST_NODE(&x->bydst);
|
||||
|
Reference in New Issue
Block a user