From 8886c44f87cbee41fd4ac1cfdf1ef6a7cb4583f5 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@hovoldconsulting.com>
Date: Mon, 22 Feb 2016 18:50:54 +0100
Subject: [PATCH] greybus: Documentation/sysfs: add module devices
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Introduce module devices and rename interface and bundle devices.
Greybus module devices correspond to physical modules and have one or
more interfaces. Modules have an id that is identical to the id of their
primary interface, which in turn is the interface with lowest numbered
id. The module name is constructed from the bus and module id:
<bus_id>-<module_id>
Interfaces and bundles are consequently renamed as
<bus_id>-<module_id>.<interface_id>
and
<bus_id>-<module_id>.<interface_id>.<bundle_id>
respectively.
As before, interface ids (and therefore in a sense now also module ids)
correspond to physical interface positions on the frame.
Modules have the following attributes:
eject
module_id
num_interfaces
where module_id is the id of the module and num_interface the number of
interfaces the module has.
Note that the interface ids of a module's interfaces are expected to be
<module_id>, <module_id + 1>, ..., <module_id + num_interfaces - 1>.
Writing a non-zero argument to eject cleanly shuts down and unregisters
all of the module interfaces before ejecting the module.
The example sysfs tree now looks as follows with the second bus
(APBridgeA) left out:
greybus1/
├── 1-2
│ ├── 1-2.2
│ │ ├── 1-2.2.1
│ │ │ ├── bundle_class
│ │ │ ├── bundle_id
│ │ │ └── state
│ │ ├── 1-2.2.2
│ │ │ ├── bundle_class
│ │ │ ├── bundle_id
│ │ │ └── state
│ │ ├── ddbl1_manufacturer_id
│ │ ├── ddbl1_product_id
│ │ ├── interface_id
│ │ ├── product_id
│ │ ├── serial_number
│ │ ├── unique_id
│ │ └── vendor_id
│ ├── eject
│ ├── module_id
│ └── num_interfaces
├── 1-4
│ ├── 1-4.4
│ │ ├── 1-4.4.2
│ │ │ ├── bundle_class
│ │ │ ├── bundle_id
│ │ │ ├── gpbridge0
│ │ │ │ ├── gpio
│ │ │ │ │ └── gpiochip490
│ │ │ │ └── i2c-4
│ │ │ └── state
│ │ ├── ddbl1_manufacturer_id
│ │ ├── ddbl1_product_id
│ │ ├── interface_id
│ │ ├── product_id
│ │ ├── serial_number
│ │ ├── unique_id
│ │ └── vendor_id
│ ├── eject
│ ├── module_id
│ └── num_interfaces
└── 1-svc
├── ap_intf_id
├── eject
└── endo_id
where greybus1 is a bus; 1-svc the svc; 1-2, and 1-4 are modules; 1-2.2
and 1-4.4 are (primary) interfaces; and 1-2.2.1, 1-2.2.2, and 1-4.4.2
are bundles.
Note that the svc eject attribute may eventually be renamed force_eject.
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---
.../sysfs/greybus1/1-2/{1-2.1 => 1-2.2/1-2.2.1}/bundle_class | 0
.../sysfs/greybus1/1-2/{1-2.1 => 1-2.2/1-2.2.1}/bundle_id | 0
.../sysfs/greybus1/1-2/{1-2.1 => 1-2.2/1-2.2.1}/state | 0
.../sysfs/greybus1/1-2/1-2.2/{ => 1-2.2.2}/bundle_class | 0
.../sysfs/greybus1/1-2/1-2.2/{ => 1-2.2.2}/bundle_id | 0
.../Documentation/sysfs/greybus1/1-2/1-2.2/{ => 1-2.2.2}/state | 0
.../sysfs/greybus1/1-2/{ => 1-2.2}/ddbl1_manufacturer_id | 0
.../sysfs/greybus1/1-2/{ => 1-2.2}/ddbl1_product_id | 0
.../Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/interface_id | 0
.../Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/product_id | 0
.../Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/serial_number | 0
.../Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/unique_id | 0
.../Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/vendor_id | 0
.../sysfs/greybus1/{1-4/1-4.2/bundle_class => 1-2/eject} | 0
.../sysfs/greybus1/{1-4/1-4.2/bundle_id => 1-2/module_id} | 0
.../2-3/2-3.1/bundle_id => greybus1/1-2/num_interfaces} | 0
.../2-3/2-3.1 => greybus1/1-4/1-4.4/1-4.4.2}/bundle_class | 0
.../Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/bundle_id | 1 +
.../1-4.4.2}/gpbridge0/gpio/gpiochip490/.gitignore | 0
.../1-4/{1-4.2 => 1-4.4/1-4.4.2}/gpbridge0/i2c-4/.gitignore | 0
.../sysfs/greybus1/1-4/{1-4.2 => 1-4.4/1-4.4.2}/state | 0
.../sysfs/greybus1/1-4/{ => 1-4.4}/ddbl1_manufacturer_id | 0
.../sysfs/greybus1/1-4/{ => 1-4.4}/ddbl1_product_id | 0
.../Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/interface_id | 0
.../Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/product_id | 0
.../Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/serial_number | 0
.../Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/unique_id | 0
.../Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/vendor_id | 0
.../sysfs/{greybus2/2-3/2-3.1/state => greybus1/1-4/eject} | 0
.../staging/greybus/Documentation/sysfs/greybus1/1-4/module_id | 1 +
.../greybus/Documentation/sysfs/greybus1/1-4/num_interfaces | 1 +
.../2-3/{ddbl1_manufacturer_id => 2-3.3/2-3.3.1/bundle_class} | 0
.../Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/bundle_id | 1 +
.../sysfs/greybus2/2-3/{ddbl1_product_id => 2-3.3/2-3.3.1/state} | 0
.../greybus2/2-3/{product_id => 2-3.3/ddbl1_manufacturer_id} | 0
.../sysfs/greybus2/2-3/{serial_number => 2-3.3/ddbl1_product_id} | 0
.../Documentation/sysfs/greybus2/2-3/{ => 2-3.3}/interface_id | 0
.../sysfs/greybus2/2-3/{unique_id => 2-3.3/product_id} | 0
.../sysfs/greybus2/2-3/{vendor_id => 2-3.3/serial_number} | 0
.../greybus/Documentation/sysfs/greybus2/2-3/2-3.3/unique_id | 0
.../greybus/Documentation/sysfs/greybus2/2-3/2-3.3/vendor_id | 0
drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/eject | 0
.../staging/greybus/Documentation/sysfs/greybus2/2-3/module_id | 1 +
.../greybus/Documentation/sysfs/greybus2/2-3/num_interfaces | 1 +
44 files changed, 6 insertions(+)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{1-2.1 => 1-2.2/1-2.2.1}/bundle_class (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{1-2.1 => 1-2.2/1-2.2.1}/bundle_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{1-2.1 => 1-2.2/1-2.2.1}/state (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/{ => 1-2.2.2}/bundle_class (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/{ => 1-2.2.2}/bundle_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/{ => 1-2.2.2}/state (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/ddbl1_manufacturer_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/ddbl1_product_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/interface_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/product_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/serial_number (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/unique_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/{ => 1-2.2}/vendor_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/{1-4/1-4.2/bundle_class => 1-2/eject} (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/{1-4/1-4.2/bundle_id => 1-2/module_id} (100%)
rename drivers/staging/greybus/Documentation/sysfs/{greybus2/2-3/2-3.1/bundle_id => greybus1/1-2/num_interfaces} (100%)
rename drivers/staging/greybus/Documentation/sysfs/{greybus2/2-3/2-3.1 => greybus1/1-4/1-4.4/1-4.4.2}/bundle_class (100%)
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/bundle_id
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{1-4.2 => 1-4.4/1-4.4.2}/gpbridge0/gpio/gpiochip490/.gitignore (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{1-4.2 => 1-4.4/1-4.4.2}/gpbridge0/i2c-4/.gitignore (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{1-4.2 => 1-4.4/1-4.4.2}/state (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/ddbl1_manufacturer_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/ddbl1_product_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/interface_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/product_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/serial_number (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/unique_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/{ => 1-4.4}/vendor_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/{greybus2/2-3/2-3.1/state => greybus1/1-4/eject} (100%)
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/module_id
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/num_interfaces
rename drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/{ddbl1_manufacturer_id => 2-3.3/2-3.3.1/bundle_class} (100%)
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/bundle_id
rename drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/{ddbl1_product_id => 2-3.3/2-3.3.1/state} (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/{product_id => 2-3.3/ddbl1_manufacturer_id} (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/{serial_number => 2-3.3/ddbl1_product_id} (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/{ => 2-3.3}/interface_id (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/{unique_id => 2-3.3/product_id} (100%)
rename drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/{vendor_id => 2-3.3/serial_number} (100%)
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/unique_id
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/vendor_id
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/eject
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/module_id
create mode 100644 drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/num_interfaces
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.1/bundle_class b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.1/bundle_class
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.1/bundle_class
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.1/bundle_class
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.1/bundle_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.1/bundle_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.1/bundle_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.1/bundle_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.1/state b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.1/state
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.1/state
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.1/state
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/bundle_class b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.2/bundle_class
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/bundle_class
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.2/bundle_class
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/bundle_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.2/bundle_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/bundle_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.2/bundle_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/state b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.2/state
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/state
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/1-2.2.2/state
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/ddbl1_manufacturer_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/ddbl1_manufacturer_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/ddbl1_manufacturer_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/ddbl1_manufacturer_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/ddbl1_product_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/ddbl1_product_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/ddbl1_product_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/ddbl1_product_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/interface_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/interface_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/interface_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/interface_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/product_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/product_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/product_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/product_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/serial_number b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/serial_number
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/serial_number
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/serial_number
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/unique_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/unique_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/unique_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/unique_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/vendor_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/vendor_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/vendor_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/1-2.2/vendor_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/bundle_class b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/eject
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/bundle_class
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/eject
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/bundle_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/module_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/bundle_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/module_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.1/bundle_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/num_interfaces
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.1/bundle_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-2/num_interfaces
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.1/bundle_class b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/bundle_class
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.1/bundle_class
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/bundle_class
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/bundle_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/bundle_id
new file mode 100644
index 000000000000..0cfbf08886fc
--- /dev/null
+++ b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/bundle_id
@@ -0,0 +1 @@
+2
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/gpbridge0/gpio/gpiochip490/.gitignore b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/gpbridge0/gpio/gpiochip490/.gitignore
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/gpbridge0/gpio/gpiochip490/.gitignore
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/gpbridge0/gpio/gpiochip490/.gitignore
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/gpbridge0/i2c-4/.gitignore b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/gpbridge0/i2c-4/.gitignore
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/gpbridge0/i2c-4/.gitignore
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/gpbridge0/i2c-4/.gitignore
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/state b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/state
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.2/state
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/1-4.4.2/state
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/ddbl1_manufacturer_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/ddbl1_manufacturer_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/ddbl1_manufacturer_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/ddbl1_manufacturer_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/ddbl1_product_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/ddbl1_product_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/ddbl1_product_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/ddbl1_product_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/interface_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/interface_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/interface_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/interface_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/product_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/product_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/product_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/product_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/serial_number b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/serial_number
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/serial_number
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/serial_number
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/unique_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/unique_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/unique_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/unique_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/vendor_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/vendor_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/vendor_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/1-4.4/vendor_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.1/state b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/eject
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.1/state
rename to drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/eject
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/module_id b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/module_id
new file mode 100644
index 000000000000..b8626c4cff28
--- /dev/null
+++ b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/module_id
@@ -0,0 +1 @@
+4
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/num_interfaces b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/num_interfaces
new file mode 100644
index 000000000000..d00491fd7e5b
--- /dev/null
+++ b/drivers/staging/greybus/Documentation/sysfs/greybus1/1-4/num_interfaces
@@ -0,0 +1 @@
+1
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/ddbl1_manufacturer_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/bundle_class
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/ddbl1_manufacturer_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/bundle_class
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/bundle_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/bundle_id
new file mode 100644
index 000000000000..d00491fd7e5b
--- /dev/null
+++ b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/bundle_id
@@ -0,0 +1 @@
+1
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/ddbl1_product_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/state
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/ddbl1_product_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/2-3.3.1/state
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/product_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/ddbl1_manufacturer_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/product_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/ddbl1_manufacturer_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/serial_number b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/ddbl1_product_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/serial_number
rename to drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/ddbl1_product_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/interface_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/interface_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/interface_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/interface_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/unique_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/product_id
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/unique_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/product_id
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/vendor_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/serial_number
similarity index 100%
rename from drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/vendor_id
rename to drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/serial_number
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/unique_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/unique_id
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/vendor_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/2-3.3/vendor_id
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/eject b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/eject
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/module_id b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/module_id
new file mode 100644
index 000000000000..00750edc07d6
--- /dev/null
+++ b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/module_id
@@ -0,0 +1 @@
+3
diff --git a/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/num_interfaces b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/num_interfaces
new file mode 100644
index 000000000000..d00491fd7e5b
--- /dev/null
+++ b/drivers/staging/greybus/Documentation/sysfs/greybus2/2-3/num_interfaces
@@ -0,0 +1 @@
+1