iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: rtl8188eu: set pipe only once

Browse Source 
Set the pipe for reading or writing in usbctrl_vendorreq only once. There's
no need to set it again for every retry.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210407170531.29356-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Martin Kaiser 2021-04-07 19:05:26 +02:00 committed by Greg Kroah-Hartman
parent b048a8db29
commit 889ed8b5e3
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
View File

@ -249,18 +249,20 @@ usbctrl_vendorreq(struct adapter *adapt, u16 value, void *pdata, u16 len, u8 req
goto release_mutex; goto release_mutex;
} }
while (++vendorreq_times <= MAX_USBCTRL_VENDORREQ_TIMES) { if (reqtype == REALTEK_USB_VENQT_READ) {
memset(pIo_buf, 0, len); pipe = usb_rcvctrlpipe(udev, 0);
} else if (reqtype == REALTEK_USB_VENQT_WRITE) {
pipe = usb_sndctrlpipe(udev, 0);
} else {
status = -EINVAL;
goto free_buf;
}
if (reqtype == REALTEK_USB_VENQT_READ) { while (++vendorreq_times <= MAX_USBCTRL_VENDORREQ_TIMES) {
pipe = usb_rcvctrlpipe(udev, 0);/* read_in */ if (reqtype == REALTEK_USB_VENQT_READ)
} else if (reqtype == REALTEK_USB_VENQT_WRITE) { memset(pIo_buf, 0, len);
pipe = usb_sndctrlpipe(udev, 0);/* write_out */ else
memcpy(pIo_buf, pdata, len); memcpy(pIo_buf, pdata, len);
} else {
status = -EINVAL;
goto free_buf;
}
status = usb_control_msg(udev, pipe, REALTEK_USB_VENQT_CMD_REQ, status = usb_control_msg(udev, pipe, REALTEK_USB_VENQT_CMD_REQ,
reqtype, value, REALTEK_USB_VENQT_CMD_IDX, reqtype, value, REALTEK_USB_VENQT_CMD_IDX,