iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: phy: smsc: add helper smsc_phy_config_edpd

Browse Source 
Add helper smsc_phy_config_edpd() and explicitly clear bit
MII_LAN83C185_EDPWRDOWN is edpd_enable isn't set.
Boot loader may have left whatever value.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Heiner Kallweit 2023-04-02 17:12:20 +02:00 committed by David S. Miller
parent fc281d78b6
commit 89946e31ff
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/net/phy/smsc.c
View File

@ -77,6 +77,18 @@ int smsc_phy_config_intr(struct phy_device *phydev)
}
EXPORT_SYMBOL_GPL(smsc_phy_config_intr);
static int smsc_phy_config_edpd(struct phy_device *phydev)
{
struct smsc_phy_priv *priv = phydev->priv;
if (priv->edpd_enable)
return phy_set_bits(phydev, MII_LAN83C185_CTRL_STATUS,
MII_LAN83C185_EDPWRDOWN);
else
return phy_clear_bits(phydev, MII_LAN83C185_CTRL_STATUS,
MII_LAN83C185_EDPWRDOWN);
}
irqreturn_t smsc_phy_handle_interrupt(struct phy_device *phydev)
{
int irq_status;
@ -105,9 +117,7 @@ int smsc_phy_config_init(struct phy_device *phydev)
if (!priv || !priv->edpd_enable || phydev->irq != PHY_POLL)
return 0;
/* Enable energy detect power down mode */
return phy_set_bits(phydev, MII_LAN83C185_CTRL_STATUS,
MII_LAN83C185_EDPWRDOWN);
return smsc_phy_config_edpd(phydev);
}
EXPORT_SYMBOL_GPL(smsc_phy_config_init);