iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cxl/mbox: Use __le32 in get,set_lsa mailbox structures

Browse Source 
CXL specification defines these as little endian.

Fixes: 60b8f17215 ("cxl/pmem: Translate NVDIMM label commands to CXL label commands")
Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Link: https://lore.kernel.org/r/20220225221456.1025635-1-alison.schofield@intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Alison Schofield
2022-02-25 14:14:56 -08:00
committed by Dan Williams
parent 8ae3cebc17
commit 8a66487506
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/cxl/cxlmem.h
View File

@@ -300,13 +300,13 @@ struct cxl_mbox_identify {
} __packed; } __packed;
struct cxl_mbox_get_lsa { struct cxl_mbox_get_lsa {
u32 offset; __le32 offset;
u32 length; __le32 length;
} __packed; } __packed;
struct cxl_mbox_set_lsa { struct cxl_mbox_set_lsa {
u32 offset; __le32 offset;
u32 reserved; __le32 reserved;
u8 data[]; u8 data[];
} __packed; } __packed;

6
drivers/cxl/pmem.c
View File

@@ -108,8 +108,8 @@ static int cxl_pmem_get_config_data(struct cxl_dev_state *cxlds,
return -EINVAL; return -EINVAL;
get_lsa = (struct cxl_mbox_get_lsa) { get_lsa = (struct cxl_mbox_get_lsa) {
.offset = cmd->in_offset, .offset = cpu_to_le32(cmd->in_offset),
.length = cmd->in_length, .length = cpu_to_le32(cmd->in_length),
}; };
rc = cxl_mbox_send_cmd(cxlds, CXL_MBOX_OP_GET_LSA, &get_lsa, rc = cxl_mbox_send_cmd(cxlds, CXL_MBOX_OP_GET_LSA, &get_lsa,
@@ -139,7 +139,7 @@ static int cxl_pmem_set_config_data(struct cxl_dev_state *cxlds,
return -ENOMEM; return -ENOMEM;
*set_lsa = (struct cxl_mbox_set_lsa) { *set_lsa = (struct cxl_mbox_set_lsa) {
.offset = cmd->in_offset, .offset = cpu_to_le32(cmd->in_offset),
}; };
memcpy(set_lsa->data, cmd->in_buf, cmd->in_length); memcpy(set_lsa->data, cmd->in_buf, cmd->in_length);