iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libceph: evaluate osd_req_op_data() arguments only once

Browse Source 
This patch changes the osd_req_op_data() macro to not evaluate
arguments more than once in order to follow the kernel coding style.

Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
Reviewed-by: Alex Elder <elder@linaro.org>
[idryomov@gmail.com: changelog, formatting]
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Ioana Ciornei
2015-10-22 18:06:07 +03:00
committed by Ilya Dryomov
parent 68cd5b4b76
commit 8a703a383d
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
net/ceph/osd_client.c
View File

@ -120,11 +120,13 @@ static void ceph_osd_data_bio_init(struct ceph_osd_data *osd_data,
} }
#endif /* CONFIG_BLOCK */ #endif /* CONFIG_BLOCK */
#define osd_req_op_data(oreq, whch, typ, fld) \ #define osd_req_op_data(oreq, whch, typ, fld) \
({ \ ({ \
BUG_ON(whch >= (oreq)->r_num_ops); \ struct ceph_osd_request *__oreq = (oreq); \
&(oreq)->r_ops[whch].typ.fld; \ unsigned int __whch = (whch); \
}) BUG_ON(__whch >= __oreq->r_num_ops); \
&__oreq->r_ops[__whch].typ.fld; \
})
static struct ceph_osd_data * static struct ceph_osd_data *
osd_req_op_raw_data_in(struct ceph_osd_request *osd_req, unsigned int which) osd_req_op_raw_data_in(struct ceph_osd_request *osd_req, unsigned int which)