iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bluetooth: mgmt: Introduce mgmt_alloc_skb and mgmt_send_event_skb

Browse Source 
This introduces mgmt_alloc_skb and mgmt_send_event_skb which are
convenient when building MGMT events that have variable length as the
likes of skb_put_data can be used to insert portion directly on the skb
instead of having to first build an intermediate buffer just to be
copied over the skb.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
This commit is contained in:
Luiz Augusto von Dentz
2021-12-03 16:15:40 -08:00
committed by Marcel Holtmann
parent 995d948cf2
commit 8aca46f91c
3 changed files with 59 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/net/bluetooth/bluetooth.h
View File

@ -390,6 +390,11 @@ struct hci_ctrl {
}; };
}; };
struct mgmt_ctrl {
struct hci_dev *hdev;
u16 opcode;
};
struct bt_skb_cb { struct bt_skb_cb {
u8 pkt_type; u8 pkt_type;
u8 force_active; u8 force_active;
@ -399,6 +404,7 @@ struct bt_skb_cb {
struct l2cap_ctrl l2cap; struct l2cap_ctrl l2cap;
struct sco_ctrl sco; struct sco_ctrl sco;
struct hci_ctrl hci; struct hci_ctrl hci;
struct mgmt_ctrl mgmt;
}; };
}; };
#define bt_cb(skb) ((struct bt_skb_cb *)((skb)->cb)) #define bt_cb(skb) ((struct bt_skb_cb *)((skb)->cb))

66
net/bluetooth/mgmt_util.c
View File

@ -56,40 +56,72 @@ static struct sk_buff *create_monitor_ctrl_event(__le16 index, u32 cookie,
return skb; return skb;
} }
int mgmt_send_event(u16 event, struct hci_dev *hdev, unsigned short channel, struct sk_buff *mgmt_alloc_skb(struct hci_dev *hdev, u16 opcode,
void *data, u16 data_len, int flag, struct sock *skip_sk) unsigned int size)
{ {
struct sk_buff *skb; struct sk_buff *skb;
struct mgmt_hdr *hdr;
skb = alloc_skb(sizeof(*hdr) + data_len, GFP_KERNEL); skb = alloc_skb(sizeof(struct mgmt_hdr) + size, GFP_KERNEL);
if (!skb) if (!skb)
return -ENOMEM; return skb;
hdr = skb_put(skb, sizeof(*hdr)); skb_reserve(skb, sizeof(struct mgmt_hdr));
hdr->opcode = cpu_to_le16(event); bt_cb(skb)->mgmt.hdev = hdev;
if (hdev) bt_cb(skb)->mgmt.opcode = opcode;
hdr->index = cpu_to_le16(hdev->id);
else
hdr->index = cpu_to_le16(MGMT_INDEX_NONE);
hdr->len = cpu_to_le16(data_len);
if (data) return skb;
skb_put_data(skb, data, data_len); }
int mgmt_send_event_skb(unsigned short channel, struct sk_buff *skb, int flag,
struct sock *skip_sk)
{
struct hci_dev *hdev;
struct mgmt_hdr *hdr;
int len = skb->len;
if (!skb)
return -EINVAL;
hdev = bt_cb(skb)->mgmt.hdev;
/* Time stamp */ /* Time stamp */
__net_timestamp(skb); __net_timestamp(skb);
hci_send_to_channel(channel, skb, flag, skip_sk); /* Send just the data, without headers, to the monitor */
if (channel == HCI_CHANNEL_CONTROL) if (channel == HCI_CHANNEL_CONTROL)
hci_send_monitor_ctrl_event(hdev, event, data, data_len, hci_send_monitor_ctrl_event(hdev, bt_cb(skb)->mgmt.opcode,
skb->data, skb->len,
skb_get_ktime(skb), flag, skip_sk); skb_get_ktime(skb), flag, skip_sk);
hdr = skb_push(skb, sizeof(*hdr));
hdr->opcode = cpu_to_le16(bt_cb(skb)->mgmt.opcode);
if (hdev)
hdr->index = cpu_to_le16(hdev->id);
else
hdr->index = cpu_to_le16(MGMT_INDEX_NONE);
hdr->len = cpu_to_le16(len);
hci_send_to_channel(channel, skb, flag, skip_sk);
kfree_skb(skb); kfree_skb(skb);
return 0; return 0;
} }
int mgmt_send_event(u16 event, struct hci_dev *hdev, unsigned short channel,
void *data, u16 data_len, int flag, struct sock *skip_sk)
{
struct sk_buff *skb;
skb = mgmt_alloc_skb(hdev, event, data_len);
if (!skb)
return -ENOMEM;
if (data)
skb_put_data(skb, data, data_len);
return mgmt_send_event_skb(channel, skb, flag, skip_sk);
}
int mgmt_cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status) int mgmt_cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status)
{ {
struct sk_buff *skb, *mskb; struct sk_buff *skb, *mskb;

4
net/bluetooth/mgmt_util.h
View File

@ -32,6 +32,10 @@ struct mgmt_pending_cmd {
int (*cmd_complete)(struct mgmt_pending_cmd *cmd, u8 status); int (*cmd_complete)(struct mgmt_pending_cmd *cmd, u8 status);
}; };
struct sk_buff *mgmt_alloc_skb(struct hci_dev *hdev, u16 opcode,
unsigned int size);
int mgmt_send_event_skb(unsigned short channel, struct sk_buff *skb, int flag,
struct sock *skip_sk);
int mgmt_send_event(u16 event, struct hci_dev *hdev, unsigned short channel, int mgmt_send_event(u16 event, struct hci_dev *hdev, unsigned short channel,
void *data, u16 data_len, int flag, struct sock *skip_sk); void *data, u16 data_len, int flag, struct sock *skip_sk);
int mgmt_cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status); int mgmt_cmd_status(struct sock *sk, u16 index, u16 cmd, u8 status);