iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme-tcp: block BH in sk state_change sk callback

Browse Source 
The TCP stack can run from process context for a long time
so we should disable BH here.

Fixes: 3f2304f8c6 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Sagi Grimberg 2021-03-21 00:08:48 -07:00 committed by Christoph Hellwig
parent 79695dcd9a
commit 8b73b45d54
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/nvme/host/tcp.c
View File

@ -870,7 +870,7 @@ static void nvme_tcp_state_change(struct sock *sk)
{ {
struct nvme_tcp_queue *queue; struct nvme_tcp_queue *queue;
read_lock(&sk->sk_callback_lock); read_lock_bh(&sk->sk_callback_lock);
queue = sk->sk_user_data; queue = sk->sk_user_data;
if (!queue) if (!queue)
goto done; goto done;
@ -891,7 +891,7 @@ static void nvme_tcp_state_change(struct sock *sk)
queue->state_change(sk); queue->state_change(sk);
done: done:
read_unlock(&sk->sk_callback_lock); read_unlock_bh(&sk->sk_callback_lock);
} }
static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue) static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)