iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: usb_wwan: report failed submissions as errors

Browse Source 
Promote failed-submission messages in open() and write() to error log
level.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold 2014-05-26 19:23:31 +02:00 committed by Greg Kroah-Hartman
parent 89da4a49b9
commit 8bb7ec65d6
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/usb/serial/usb_wwan.c
View File

@ -231,9 +231,9 @@ int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port,
spin_unlock_irqrestore(&intfdata->susp_lock, flags); spin_unlock_irqrestore(&intfdata->susp_lock, flags);
err = usb_submit_urb(this_urb, GFP_ATOMIC); err = usb_submit_urb(this_urb, GFP_ATOMIC);
if (err) { if (err) {
dev_dbg(&port->dev, dev_err(&port->dev,
"usb_submit_urb %p (write bulk) failed (%d)\n", "%s: submit urb %d failed: %d\n",
this_urb, err); __func__, i, err);
clear_bit(i, &portdata->out_busy); clear_bit(i, &portdata->out_busy);
spin_lock_irqsave(&intfdata->susp_lock, flags); spin_lock_irqsave(&intfdata->susp_lock, flags);
intfdata->in_flight--; intfdata->in_flight--;
@ -376,7 +376,7 @@ int usb_wwan_open(struct tty_struct *tty, struct usb_serial_port *port)
if (port->interrupt_in_urb) { if (port->interrupt_in_urb) {
err = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); err = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
if (err) { if (err) {
dev_dbg(&port->dev, "%s: submit int urb failed: %d\n", dev_err(&port->dev, "%s: submit int urb failed: %d\n",
__func__, err); __func__, err);
} }
} }
@ -388,8 +388,9 @@ int usb_wwan_open(struct tty_struct *tty, struct usb_serial_port *port)
continue; continue;
err = usb_submit_urb(urb, GFP_KERNEL); err = usb_submit_urb(urb, GFP_KERNEL);
if (err) { if (err) {
dev_dbg(&port->dev, "%s: submit urb %d failed (%d) %d\n", dev_err(&port->dev,
__func__, i, err, urb->transfer_buffer_length); "%s: submit read urb %d failed: %d\n",
__func__, i, err);
} }
} }