iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: igb: use skb_csum_is_sctp instead of protocol check

Browse Source 
Using skb_csum_is_sctp is a easier way to validate it's a SCTP
CRC checksum offload packet, and there is no need to parse the
packet to check its proto field, especially when it's a UDP or
GRE encapped packet.

So this patch also makes igb support SCTP CRC checksum offload
for UDP and GRE encapped packets.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Xin Long 2021-01-16 14:13:38 +08:00 committed by Jakub Kicinski
parent fa82117010
commit 8bcf02035b
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/ethernet/intel/igb/igb_main.c
View File

@ -5959,15 +5959,6 @@ static int igb_tso(struct igb_ring *tx_ring,
return 1; return 1;
} }
static inline bool igb_ipv6_csum_is_sctp(struct sk_buff *skb)
{
unsigned int offset = 0;
ipv6_find_hdr(skb, &offset, IPPROTO_SCTP, NULL, NULL);
return offset == skb_checksum_start_offset(skb);
}
static void igb_tx_csum(struct igb_ring *tx_ring, struct igb_tx_buffer *first) static void igb_tx_csum(struct igb_ring *tx_ring, struct igb_tx_buffer *first)
{ {
struct sk_buff *skb = first->skb; struct sk_buff *skb = first->skb;
@ -5990,10 +5981,7 @@ csum_failed:
break; break;
case offsetof(struct sctphdr, checksum): case offsetof(struct sctphdr, checksum):
/* validate that this is actually an SCTP request */ /* validate that this is actually an SCTP request */
if (((first->protocol == htons(ETH_P_IP)) && if (skb_csum_is_sctp(skb)) {
(ip_hdr(skb)->protocol == IPPROTO_SCTP)) ||
((first->protocol == htons(ETH_P_IPV6)) &&
igb_ipv6_csum_is_sctp(skb))) {
type_tucmd = E1000_ADVTXD_TUCMD_L4T_SCTP; type_tucmd = E1000_ADVTXD_TUCMD_L4T_SCTP;
break; break;
} }