iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

memstick r592: make memstick_debug_get_tpc_name() static

Browse Source 
[ Upstream commit 434587df9f ]

There are no other files referencing this function, apparently
it was left global to avoid an 'unused function' warning when
the only caller is left out. With a 'W=1' build, it causes
a 'missing prototype' warning though:

drivers/memstick/host/r592.c:47:13: error: no previous prototype for 'memstick_debug_get_tpc_name' [-Werror=missing-prototypes]

Annotate the function as 'static __maybe_unused' to avoid both
problems.

Fixes: 9263412501 ("memstick: add driver for Ricoh R5C592 card reader")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230516202714.560929-1-arnd@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Arnd Bergmann
2023-05-16 22:27:04 +02:00
committed by Greg Kroah-Hartman
parent 79c0fbf8f3
commit 8c561a59c6
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/memstick/host/r592.c
View File

@ -44,12 +44,10 @@ static const char *tpc_names[] = {
* memstick_debug_get_tpc_name - debug helper that returns string for * memstick_debug_get_tpc_name - debug helper that returns string for
* a TPC number * a TPC number
*/ */
const char *memstick_debug_get_tpc_name(int tpc) static __maybe_unused const char *memstick_debug_get_tpc_name(int tpc)
{ {
return tpc_names[tpc-1]; return tpc_names[tpc-1];
} }
EXPORT_SYMBOL(memstick_debug_get_tpc_name);
/* Read a register*/ /* Read a register*/
static inline u32 r592_read_reg(struct r592_device *dev, int address) static inline u32 r592_read_reg(struct r592_device *dev, int address)