iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc()

Browse Source 
In case of memory allocation failure, a negative error code should
be returned.

Fixes: 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
Cc: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Tianjia Zhang 2020-08-02 19:15:32 +08:00 committed by Herbert Xu
parent e62291c1d9
commit 8cbde6c6a6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/crypto/mediatek/mtk-platform.c
View File

@ -442,7 +442,7 @@ static void mtk_desc_dma_free(struct mtk_cryp *cryp)
static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
{ {
struct mtk_ring **ring = cryp->ring; struct mtk_ring **ring = cryp->ring;
int i, err = ENOMEM; int i;
for (i = 0; i < MTK_RING_MAX; i++) { for (i = 0; i < MTK_RING_MAX; i++) {
ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL); ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL);
@ -476,7 +476,7 @@ err_cleanup:
ring[i]->cmd_base, ring[i]->cmd_dma); ring[i]->cmd_base, ring[i]->cmd_dma);
kfree(ring[i]); kfree(ring[i]);
} }
return err; return -ENOMEM;
} }
static int mtk_crypto_probe(struct platform_device *pdev) static int mtk_crypto_probe(struct platform_device *pdev)