iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: connection: simplify connection-creation interface

Browse Source 
Simplify the exported generic interface for creating dynamic
connections.

Since all driver connections will have a bundle we can drop the
redundant interface parameter.

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2016-01-21 17:34:14 +01:00 committed by Greg Kroah-Hartman
parent e4c16f8b03
commit 8cff6c6473
3 changed files with 6 additions and 7 deletions
drivers/staging/greybus
connection.cconnection.hlegacy.c

6
drivers/staging/greybus/connection.c

@ -225,10 +225,10 @@ gb_connection_create_control(struct gb_interface *intf)
}
struct gb_connection *
gb_connection_create_dynamic(struct gb_interface *intf,
struct gb_bundle *bundle,
u16 cport_id)
gb_connection_create_dynamic(struct gb_bundle *bundle, u16 cport_id)
{
struct gb_interface *intf = bundle->intf;
return gb_connection_create(intf->hd, -1, intf, bundle, cport_id);
}
EXPORT_SYMBOL_GPL(gb_connection_create_dynamic);

4
drivers/staging/greybus/connection.h

@ -58,8 +58,8 @@ struct gb_connection {
struct gb_connection *gb_connection_create_static(struct gb_host_device *hd,
u16 hd_cport_id);
struct gb_connection *gb_connection_create_control(struct gb_interface *intf);
struct gb_connection *gb_connection_create_dynamic(struct gb_interface *intf,
struct gb_bundle *bundle, u16 cport_id);
struct gb_connection *gb_connection_create_dynamic(struct gb_bundle *bundle,
u16 cport_id);
void gb_connection_destroy(struct gb_connection *connection);
static inline bool gb_connection_is_static(struct gb_connection *connection)

3
drivers/staging/greybus/legacy.c

@ -153,8 +153,7 @@ static int legacy_probe(struct gb_bundle *bundle,
for (i = 0; i < data->num_cports; ++i) {
cport_desc = &bundle->cport_desc[i];
connection = gb_connection_create_dynamic(bundle->intf,
bundle,
connection = gb_connection_create_dynamic(bundle,
le16_to_cpu(cport_desc->id));
if (!connection)
goto err_connections_destroy;