iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

workqueue: free rescuer on destroy_workqueue

Browse Source 
wq->rescuer is not freed when wq is destroyed, leads a memory leak
then. This patch also remove a redundant line.

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
This commit is contained in:
Xiaotian Feng 2010-08-16 09:54:28 +02:00 committed by Tejun Heo
parent da5cabf80e
commit 8d9df9f084
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/workqueue.c
View File

@ -2782,7 +2782,6 @@ struct workqueue_struct *__alloc_workqueue_key(const char *name,
if (IS_ERR(rescuer->task)) if (IS_ERR(rescuer->task))
goto err; goto err;
wq->rescuer = rescuer;
rescuer->task->flags |= PF_THREAD_BOUND; rescuer->task->flags |= PF_THREAD_BOUND;
wake_up_process(rescuer->task); wake_up_process(rescuer->task);
} }
@ -2848,6 +2847,7 @@ void destroy_workqueue(struct workqueue_struct *wq)
if (wq->flags & WQ_RESCUER) { if (wq->flags & WQ_RESCUER) {
kthread_stop(wq->rescuer->task); kthread_stop(wq->rescuer->task);
free_mayday_mask(wq->mayday_mask); free_mayday_mask(wq->mayday_mask);
kfree(wq->rescuer);
} }
free_cwqs(wq); free_cwqs(wq);