iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ublk_drv: fix double shift bug

Browse Source 
The test/clear_bit() functions take a bit number, but this code is
passing as shifted value.  It's the equivalent of saying BIT(BIT(0))
instead of just BIT(0).

This doesn't affect runtime because numbers are small and it's done
consistently.

Fixes: fa36204556 ("ublk: simplify ublk_ch_open and ublk_ch_release")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/Yt/2R/+MJf/MSoyl@kili
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Dan Carpenter 2022-07-26 17:12:23 +03:00 committed by Jens Axboe
parent 6d8c5afc9a
commit 8d9fdb6011
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/block/ublk_drv.c
View File

@ -127,8 +127,8 @@ struct ublk_device {
struct cdev cdev;
struct device cdev_dev;
#define UB_STATE_OPEN (1 << 0)
#define UB_STATE_USED (1 << 1)
#define UB_STATE_OPEN 0
#define UB_STATE_USED 1
unsigned long state;
int ub_number;