iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: nuc900: fix a wait loop bug

Browse Source 
The current implement meant ACTL_ACCON was only accessed once when read or write
proceeding, which is not right, if so,we have to wait the 'timeout=0x10000' to end
every times.

We need to polling the bit AC_R_FINISH and AC_W_FINISH of ACTL_ACCON
register to identify whether read or write is finished or not,so I make
the patch to fix the issue.

Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
Wan ZongShun 2010-06-02 14:02:33 +08:00 committed by Mark Brown
parent 018334c045
commit 8dfb0c7815
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sound/soc/nuc900/nuc900-ac97.c
View File

@ -66,9 +66,8 @@ static unsigned short nuc900_ac97_read(struct snd_ac97 *ac97,
udelay(100); udelay(100);
/* polling the AC_R_FINISH */ /* polling the AC_R_FINISH */
val = AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON); while (!(AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON) & AC_R_FINISH)
val &= AC_R_FINISH; && timeout--)
while (!val && timeout--)
mdelay(1); mdelay(1);
if (!timeout) { if (!timeout) {
@ -121,9 +120,8 @@ static void nuc900_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
udelay(100); udelay(100);
/* polling the AC_W_FINISH */ /* polling the AC_W_FINISH */
tmp = AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON); while ((AUDIO_READ(nuc900_audio->mmio + ACTL_ACCON) & AC_W_FINISH)
tmp &= AC_W_FINISH; && timeout--)
while (tmp && timeout--)
mdelay(1); mdelay(1);
if (!timeout) if (!timeout)