iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

video: fbdev: pvr2fb: initialize variables

Browse Source 
clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
  is an uninitialized value [core.CallAndMessage]
        if (*cable_arg)
        ^~~~~~~~~~~~~~~

Problem is that cable_arg depends on the input loop to
set the cable_arg[0].  If it does not, then some random
value from the stack is used.

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com
This commit is contained in:
Tom Rix 2020-07-20 12:18:45 -07:00 committed by Sam Ravnborg
parent d3dc135187
commit 8e1ba47c60
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/video/fbdev/pvr2fb.c
View File

@ -1028,6 +1028,8 @@ static int __init pvr2fb_setup(char *options)
if (!options || !*options) if (!options || !*options)
return 0; return 0;
cable_arg[0] = output_arg[0] = 0;
while ((this_opt = strsep(&options, ","))) { while ((this_opt = strsep(&options, ","))) {
if (!*this_opt) if (!*this_opt)
continue; continue;