iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: playstation: DS4: Fix LED blinking

Browse Source 
There was no way to disable blinking once enabled.
Disable it on brightness = 0, as per the Linux LED spec.

The driver reports back the values it sends to the controller, but they
need to be scaled back to milliseconds. Setting the LED blinking via
sysfs works as expected now.

Signed-off-by: Max Staudt <max@enpas.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
This commit is contained in:
Max Staudt 2024-02-08 01:36:43 +09:00 committed by Jiri Kosina
parent 3e78a6c0d3
commit 8f39af37eb
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/hid/hid-playstation.c
View File

@ -2037,8 +2037,9 @@ static int dualshock4_led_set_blink(struct led_classdev *led, unsigned long *del
dualshock4_schedule_work(ds4);
*delay_on = ds4->lightbar_blink_on;
*delay_off = ds4->lightbar_blink_off;
/* Report scaled values back to LED subsystem */
*delay_on = ds4->lightbar_blink_on * 10;
*delay_off = ds4->lightbar_blink_off * 10;
return 0;
}
@ -2065,6 +2066,13 @@ static int dualshock4_led_set_brightness(struct led_classdev *led, enum led_brig
break;
case 3:
ds4->lightbar_enabled = !!value;
/* brightness = 0 also cancels blinking in Linux. */
if (!ds4->lightbar_enabled) {
ds4->lightbar_blink_off = 0;
ds4->lightbar_blink_on = 0;
ds4->update_lightbar_blink = true;
}
}
ds4->update_lightbar = true;