iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: debug: fix error handling in hid_debug_events_read()

Browse Source 
In the unlikely case of hdev vanishing while hid_debug_events_read() was
sleeping, we can't really break out of the case switch as with other cases,
as on the way out we'll try to remove ourselves from the hdev waitqueue.

Fix this by taking a shortcut exit path and avoiding cleanup that doesn't
make sense in case hdev doesn't exist any more anyway.

Reported-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Jiri Kosina 2015-04-09 13:32:35 +02:00
parent c627589282
commit 8fec02a73e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/hid/hid-debug.c
View File

@ -1127,7 +1127,8 @@ static ssize_t hid_debug_events_read(struct file *file, char __user *buffer,
if (!list->hdev || !list->hdev->debug) { if (!list->hdev || !list->hdev->debug) {
ret = -EIO; ret = -EIO;
break; set_current_state(TASK_RUNNING);
goto out;
} }
/* allow O_NONBLOCK from other threads */ /* allow O_NONBLOCK from other threads */