iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/xe/mocs: Drop HAS_RENDER_L3CC flag

Browse Source 
The HAS_RENDER_L3CC is set unconditionally so there's no need to keep it
as a dedicated flag.  For error checking purposes, we can just make sure
the 'table' field is initialized properly.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
This commit is contained in:
Matt Roper 2023-02-23 10:57:40 -08:00 committed by Rodrigo Vivi
parent f659ac1564
commit 90385dcfc0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpu/drm/xe/xe_mocs.c
View File

@ -25,7 +25,6 @@ static inline void mocs_dbg(const struct drm_device *dev,
enum {
HAS_GLOBAL_MOCS = BIT(0),
HAS_RENDER_L3CC = BIT(1),
};
struct xe_mocs_entry {
@ -440,10 +439,11 @@ static unsigned int get_mocs_settings(struct xe_device *xe,
*/
XE_WARN_ON(info->unused_entries_index == 0);
if (XE_WARN_ON(info->size > info->n_entries))
if (XE_WARN_ON(info->size > info->n_entries)) {
info->table = NULL;
return 0;
}
flags = HAS_RENDER_L3CC;
if (!IS_DGFX(xe))
flags |= HAS_GLOBAL_MOCS;
@ -538,6 +538,6 @@ void xe_mocs_init(struct xe_gt *gt)
* sure the LNCFCMOCSx registers are programmed for the subsequent
* memory transactions including guc transactions
*/
if (flags & HAS_RENDER_L3CC)
if (table.table)
init_l3cc_table(gt, &table);
}