iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qede: fix interrupt coalescing configuration

Browse Source 
On default driver load device gets configured with unexpected
higher interrupt coalescing values instead of default expected
values as memory allocated from krealloc() is not supposed to
be zeroed out and may contain garbage values.

Fix this by allocating the memory of required size first with
kcalloc() and then use krealloc() to resize and preserve the
contents across down/up of the interface.

Signed-off-by: Manish Chopra <manishc@marvell.com>
Fixes: b0ec5489c480 ("qede: preserve per queue stats across up/down of interface")
Cc: stable@vger.kernel.org
Cc: Bhaskar Upadhaya <bupadhaya@marvell.com>
Cc: David S. Miller <davem@davemloft.net>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2160054
Signed-off-by: Alok Prasad <palok@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Manish Chopra 2023-02-16 03:54:47 -08:00 committed by David S. Miller
parent 475f9ff63e
commit 908d4bb7c5
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/ethernet/qlogic/qede/qede_main.c
View File

@ -970,8 +970,15 @@ static int qede_alloc_fp_array(struct qede_dev *edev)
goto err; goto err;
} }
mem = krealloc(edev->coal_entry, QEDE_QUEUE_CNT(edev) * if (!edev->coal_entry) {
sizeof(*edev->coal_entry), GFP_KERNEL); mem = kcalloc(QEDE_MAX_RSS_CNT(edev),
sizeof(*edev->coal_entry), GFP_KERNEL);
} else {
mem = krealloc(edev->coal_entry,
QEDE_QUEUE_CNT(edev) * sizeof(*edev->coal_entry),
GFP_KERNEL);
}
if (!mem) { if (!mem) {
DP_ERR(edev, "coalesce entry allocation failed\n"); DP_ERR(edev, "coalesce entry allocation failed\n");
kfree(edev->coal_entry); kfree(edev->coal_entry);