iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

f2fs: fix to set noatime and immutable flag for quota file

Browse Source 
We should set noatime bit for quota files, since no one cares about
atime of quota file, and we should set immutalbe bit as well, due to
nobody should write to the file through exported interfaces.

Meanwhile this patch use inode_lock to avoid race condition during
inode->i_flags, f2fs_inode->i_flags update.

Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Chao Yu 2023-05-27 08:15:39 +08:00 committed by Jaegeuk Kim
parent 77e820ea73
commit 90b7c4b748
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/f2fs/super.c
View File

@ -2748,6 +2748,7 @@ static int f2fs_quota_enable(struct super_block *sb, int type, int format_id,
{
struct inode *qf_inode;
unsigned long qf_inum;
unsigned long qf_flag = F2FS_NOATIME_FL | F2FS_IMMUTABLE_FL;
int err;
BUG_ON(!f2fs_sb_has_quota_ino(F2FS_SB(sb)));
@ -2763,7 +2764,15 @@ static int f2fs_quota_enable(struct super_block *sb, int type, int format_id,
}
/* Don't account quota for quota files to avoid recursion */
inode_lock(qf_inode);
qf_inode->i_flags |= S_NOQUOTA;
if ((F2FS_I(qf_inode)->i_flags & qf_flag) != qf_flag) {
F2FS_I(qf_inode)->i_flags |= qf_flag;
f2fs_set_inode_flags(qf_inode);
}
inode_unlock(qf_inode);
err = dquot_load_quota_inode(qf_inode, type, format_id, flags);
iput(qf_inode);
return err;