iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reset: ath79: make it explicitly non-modular

Browse Source 
The Kconfig currently controlling compilation of this code is:

drivers/reset/Kconfig:config RESET_ATH79
drivers/reset/Kconfig:  bool "AR71xx Reset Driver" if COMPILE_TEST

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

We explicitly disallow a driver unbind, since that doesn't have a
sensible use case anyway, and it allows us to drop the ".remove"
code for non-modular drivers.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Alban Bedel <albeu@free.fr>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Alban Bedel <albeu@free.fr>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This commit is contained in:
Paul Gortmaker 2017-02-07 19:18:44 -05:00 committed by Philipp Zabel
parent 80b8b1a15c
commit 90ce95ab3d
1 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/reset/reset-ath79.c
View File

@ -1,4 +1,7 @@
/* /*
* AR71xx Reset Controller Driver
* Author: Alban Bedel
*
* Copyright (C) 2015 Alban Bedel <albeu@free.fr> * Copyright (C) 2015 Alban Bedel <albeu@free.fr>
* *
* This program is free software; you can redistribute it and/or modify * This program is free software; you can redistribute it and/or modify
@ -13,7 +16,7 @@
*/ */
#include <linux/io.h> #include <linux/io.h>
#include <linux/module.h> #include <linux/init.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/reset-controller.h> #include <linux/reset-controller.h>
#include <linux/reboot.h> #include <linux/reboot.h>
@ -127,31 +130,17 @@ static int ath79_reset_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int ath79_reset_remove(struct platform_device *pdev)
{
struct ath79_reset *ath79_reset = platform_get_drvdata(pdev);
unregister_restart_handler(&ath79_reset->restart_nb);
return 0;
}
static const struct of_device_id ath79_reset_dt_ids[] = { static const struct of_device_id ath79_reset_dt_ids[] = {
{ .compatible = "qca,ar7100-reset", }, { .compatible = "qca,ar7100-reset", },
{ }, { },
}; };
MODULE_DEVICE_TABLE(of, ath79_reset_dt_ids);
static struct platform_driver ath79_reset_driver = { static struct platform_driver ath79_reset_driver = {
.probe = ath79_reset_probe, .probe = ath79_reset_probe,
.remove = ath79_reset_remove,
.driver = { .driver = {
.name = "ath79-reset", .name = "ath79-reset",
.of_match_table = ath79_reset_dt_ids, .of_match_table = ath79_reset_dt_ids,
.suppress_bind_attrs = true,
}, },
}; };
module_platform_driver(ath79_reset_driver); builtin_platform_driver(ath79_reset_driver);
MODULE_AUTHOR("Alban Bedel <albeu@free.fr>");
MODULE_DESCRIPTION("AR71xx Reset Controller Driver");
MODULE_LICENSE("GPL");