iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/amd/display: Gamma logic limitations causing unintended use of RAM over ROM.

Browse Source 
[Why]
Our existing logic in deciding whether to use RAM or ROM
depends on whether we are dealing with an identity gamma ramp.

[How]
In addition to the is_identity flag
a new is_logical_identity flag has been
added. The is_identity flag now denotes
whether the OS gamma is an RGB256 identity
and the new logical identity will inidicate
that the given gamma ramp regardless of its
type is identity.

Signed-off-by: Harmanprit Tatla <harmanprit.tatla@amd.com>
Reviewed-by: Krunoslav Kovac <Krunoslav.Kovac@amd.com>
Acked-by: Anthony Koo <Anthony.Koo@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Harmanprit Tatla 2019-05-27 14:22:30 -04:00 committed by Alex Deucher
parent 9ed43ef84d
commit 910954da2c
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/amd/display/dc/dc_hw_types.h
View File

@ -453,7 +453,11 @@ struct dc_gamma {
/* private to DC core */
struct dc_context *ctx;
/* is_identity is used for RGB256 gamma identity which can also be programmed in INPUT_LUT.
* is_logical_identity indicates the given gamma ramp regardless of type is identity.
*/
bool is_identity;
bool is_logical_identity;
};
/* Used by both ipp amd opp functions*/

3
drivers/gpu/drm/amd/display/modules/color/color_gamma.c
View File

@ -1569,7 +1569,8 @@ bool mod_color_calculate_regamma_params(struct dc_transfer_func *output_tf,
output_tf->tf == TRANSFER_FUNCTION_SRGB) {
if (ramp == NULL)
return true;
if (ramp->is_identity || (!mapUserRamp && ramp->type == GAMMA_RGB_256))
if ((ramp->is_logical_identity) ||
(!mapUserRamp && ramp->type == GAMMA_RGB_256))
return true;
}