iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nexthop: fix uninitialized variable in nla_put_nh_group_stats()

Browse Source 
The "*hw_stats_used" value needs to be set on the success paths to prevent
an uninitialized variable bug in the caller, nla_put_nh_group_stats().

Fixes: 5072ae00ae ("net: nexthop: Expose nexthop group HW stats to user space")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/f08ac289-d57f-4a1a-830f-cf9a0563cb9c@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Dan Carpenter 2024-03-21 17:42:18 +03:00 committed by Jakub Kicinski
parent f6c8f5e869
commit 9145e2249e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/ipv4/nexthop.c
View File

@ -768,8 +768,10 @@ static int nh_grp_hw_stats_update(struct nexthop *nh, bool *hw_stats_used)
struct net *net = nh->net; struct net *net = nh->net;
int err; int err;
if (nexthop_notifiers_is_empty(net)) if (nexthop_notifiers_is_empty(net)) {
*hw_stats_used = false;
return 0; return 0;
}
err = nh_notifier_grp_hw_stats_init(&info, nh); err = nh_notifier_grp_hw_stats_init(&info, nh);
if (err) if (err)