iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sched/core: Fix the bug that task won't enqueue into core tree when update cookie

Browse Source 
In function sched_core_update_cookie(), a task will enqueue into the
core tree only when it enqueued before, that is, if an uncookied task
is cookied, it will not enqueue into the core tree until it enqueue
again, which will result in unnecessary force idle.

Here follows the scenario:
  CPU x and CPU y are a pair of SMT siblings.
  1. Start task a running on CPU x without sleeping, and task b and
     task c running on CPU y without sleeping.
  2. We create a cookie and share it to task a and task b, and then
     we create another cookie and share it to task c.
  3. Simpling core_forceidle_sum of task a and b from /proc/PID/sched

And we will find out that core_forceidle_sum of task a takes 30%
time of the sampling period, which shouldn't happen as task a and b
have the same cookie.

Then we migrate task a to CPU x', migrate task b and c to CPU y', where
CPU x' and CPU y' are a pair of SMT siblings, and sampling again, we
will found out that core_forceidle_sum of task a and b are almost zero.

To solve this problem, we enqueue the task into the core tree if it's
on rq.

Fixes: 6e33cad0af49("sched: Trivial core scheduling cookie management")
Signed-off-by: Cruz Zhao <CruzZhao@linux.alibaba.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/1656403045-100840-2-git-send-email-CruzZhao@linux.alibaba.com
This commit is contained in:
Cruz Zhao 2022-06-28 15:57:23 +08:00 committed by Peter Zijlstra
parent 5c66d1b9b3
commit 91caa5ae24
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
kernel/sched/core_sched.c
View File

@ -56,7 +56,6 @@ static unsigned long sched_core_update_cookie(struct task_struct *p,
unsigned long old_cookie; unsigned long old_cookie;
struct rq_flags rf; struct rq_flags rf;
struct rq *rq; struct rq *rq;
bool enqueued;
rq = task_rq_lock(p, &rf); rq = task_rq_lock(p, &rf);
@ -68,14 +67,16 @@ static unsigned long sched_core_update_cookie(struct task_struct *p,
*/ */
SCHED_WARN_ON((p->core_cookie || cookie) && !sched_core_enabled(rq)); SCHED_WARN_ON((p->core_cookie || cookie) && !sched_core_enabled(rq));
enqueued = sched_core_enqueued(p); if (sched_core_enqueued(p))
if (enqueued)
sched_core_dequeue(rq, p, DEQUEUE_SAVE); sched_core_dequeue(rq, p, DEQUEUE_SAVE);
old_cookie = p->core_cookie; old_cookie = p->core_cookie;
p->core_cookie = cookie; p->core_cookie = cookie;
if (enqueued) /*
* Consider the cases: !prev_cookie and !cookie.
*/
if (cookie && task_on_rq_queued(p))
sched_core_enqueue(rq, p); sched_core_enqueue(rq, p);
/* /*