iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: musb: da8xx: Switch to use dev_err_probe() helper

Browse Source 
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927072616.913672-3-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Yang Yingliang 2022-09-27 15:26:13 +08:00 committed by Greg Kroah-Hartman
parent 7be7231d41
commit 92150ca664
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/musb/da8xx.c
View File

@ -523,11 +523,9 @@ static int da8xx_probe(struct platform_device *pdev)
} }
glue->phy = devm_phy_get(&pdev->dev, "usb-phy"); glue->phy = devm_phy_get(&pdev->dev, "usb-phy");
if (IS_ERR(glue->phy)) { if (IS_ERR(glue->phy))
if (PTR_ERR(glue->phy) != -EPROBE_DEFER) return dev_err_probe(&pdev->dev, PTR_ERR(glue->phy),
dev_err(&pdev->dev, "failed to get phy\n"); "failed to get phy\n");
return PTR_ERR(glue->phy);
}
glue->dev = &pdev->dev; glue->dev = &pdev->dev;
glue->clk = clk; glue->clk = clk;