iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dmaengine: mcf-edma: Use struct_size()

Browse Source 
Use struct_size() instead of hand writing it.
This is less verbose and more informative.

'mcf_chan' is now unused and can be removed. In fact, it is shadowed by
another variable in the 'for' loop below. Keep this one.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/97c2bb1c9b69d0739da3762a7752ae6582c4ad02.1683390112.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Christophe JAILLET 2023-05-06 18:22:06 +02:00 committed by Vinod Koul
parent 8674ca3950
commit 923b138388
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/dma/mcf-edma.c
View File

@ -180,9 +180,8 @@ static int mcf_edma_probe(struct platform_device *pdev)
{
struct mcf_edma_platform_data *pdata;
struct fsl_edma_engine *mcf_edma;
struct fsl_edma_chan *mcf_chan;
struct edma_regs *regs;
int ret, i, len, chans;
int ret, i, chans;
pdata = dev_get_platdata(&pdev->dev);
if (!pdata) {
@ -191,8 +190,8 @@ static int mcf_edma_probe(struct platform_device *pdev)
}
chans = pdata->dma_channels;
len = sizeof(*mcf_edma) + sizeof(*mcf_chan) * chans;
mcf_edma = devm_kzalloc(&pdev->dev, len, GFP_KERNEL);
mcf_edma = devm_kzalloc(&pdev->dev, struct_size(mcf_edma, chans, chans),
GFP_KERNEL);
if (!mcf_edma)
return -ENOMEM;