iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

Browse Source 
Smatch warns that:

    drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
    error: uninitialized symbol 'rc'.

"rc" is either uninitialized or set to zero here so we can just remove
the check.

Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2017-12-05 17:37:52 +03:00 committed by David S. Miller
parent b9f242047f
commit 92425c4067
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
View File

@ -148,9 +148,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
}
}
if (rc)
return rc;
if (actions->flags & BNXT_TC_ACTION_FLAG_FWD) {
if (actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP) {
/* dst_fid is PF's fid */
@ -164,7 +161,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
}
}
return rc;
return 0;
}
#define GET_KEY(flow_cmd, key_type) \