iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: simple-card: fix possible uninitialized single_cpu local variable

Browse Source 
[ Upstream commit fa74c223b6 ]

The 'single_cpu' local variable is assigned by asoc_simple_parse_dai()
and later used in a asoc_simple_canonicalize_cpu() call, assuming the
entire function did not exit on errors.

However the first function returns 0 if passed device_node is NULL,
thus leaving the variable uninitialized and reporting success.

Addresses-Coverity: Uninitialized scalar variable
Fixes: 8f7f298a33 ("ASoC: simple-card-utils: separate asoc_simple_card_parse_dai()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Acked-by: Sameer Pujar <spujar@nvidia.com>
Link: https://lore.kernel.org/r/20210407092027.60769-1-krzysztof.kozlowski@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Krzysztof Kozlowski
2021-04-07 11:20:27 +02:00
committed by Greg Kroah-Hartman
parent e1b01d914c
commit 92626cf41b
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sound/soc/generic/audio-graph-card.c
View File

@ -340,7 +340,7 @@ static int graph_dai_link_of(struct asoc_simple_priv *priv,
struct device_node *top = dev->of_node; struct device_node *top = dev->of_node;
struct asoc_simple_dai *cpu_dai; struct asoc_simple_dai *cpu_dai;
struct asoc_simple_dai *codec_dai; struct asoc_simple_dai *codec_dai;
int ret, single_cpu; int ret, single_cpu = 0;
/* Do it only CPU turn */ /* Do it only CPU turn */
if (!li->cpu) if (!li->cpu)

2
sound/soc/generic/simple-card.c
View File

@ -258,7 +258,7 @@ static int simple_dai_link_of(struct asoc_simple_priv *priv,
struct device_node *plat = NULL; struct device_node *plat = NULL;
char prop[128]; char prop[128];
char *prefix = ""; char *prefix = "";
int ret, single_cpu; int ret, single_cpu = 0;
/* /*
* |CPU |Codec : turn * |CPU |Codec : turn