iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: bonding: fix error return code of bond_neigh_init()

Browse Source 
[ Upstream commit 2055a99da8 ]

When slave is NULL or slave_ops->ndo_neigh_setup is NULL, no error
return code of bond_neigh_init() is assigned.
To fix this bug, ret is assigned with -EINVAL in these cases.

Fixes: 9e99bfefdb ("bonding: fix bond_neigh_init()")
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jia-Ju Bai
2021-03-07 19:11:02 -08:00
committed by Greg Kroah-Hartman
parent 76f496681d
commit 9392b8219b
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/bonding/bond_main.c
View File

@ -3918,11 +3918,15 @@ static int bond_neigh_init(struct neighbour *n)
rcu_read_lock(); rcu_read_lock();
slave = bond_first_slave_rcu(bond); slave = bond_first_slave_rcu(bond);
if (!slave) if (!slave) {
ret = -EINVAL;
goto out; goto out;
}
slave_ops = slave->dev->netdev_ops; slave_ops = slave->dev->netdev_ops;
if (!slave_ops->ndo_neigh_setup) if (!slave_ops->ndo_neigh_setup) {
ret = -EINVAL;
goto out; goto out;
}
/* TODO: find another way [1] to implement this. /* TODO: find another way [1] to implement this.
* Passing a zeroed structure is fragile, * Passing a zeroed structure is fragile,