iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Driver core: Don't leak 'old_class_name' in drivers/base/core.c::device_rename()

Browse Source 
If kmalloc() fails to allocate space for 'old_symlink_name' in
drivers/base/core.c::device_rename(), then we'll leak 'old_class_name'.

Spotted by the Coverity checker.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jesper Juhl 2006-09-28 23:56:01 +02:00 committed by Greg Kroah-Hartman
parent 221c324a33
commit 952ab431cd
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/base/core.c
View File

@ -809,8 +809,10 @@ int device_rename(struct device *dev, char *new_name)
if (dev->class) { if (dev->class) {
old_symlink_name = kmalloc(BUS_ID_SIZE, GFP_KERNEL); old_symlink_name = kmalloc(BUS_ID_SIZE, GFP_KERNEL);
if (!old_symlink_name) if (!old_symlink_name) {
return -ENOMEM; error = -ENOMEM;
goto out_free_old_class;
}
strlcpy(old_symlink_name, dev->bus_id, BUS_ID_SIZE); strlcpy(old_symlink_name, dev->bus_id, BUS_ID_SIZE);
} }
@ -834,9 +836,10 @@ int device_rename(struct device *dev, char *new_name)
} }
put_device(dev); put_device(dev);
kfree(old_class_name);
kfree(new_class_name); kfree(new_class_name);
kfree(old_symlink_name); kfree(old_symlink_name);
out_free_old_class:
kfree(old_class_name);
return error; return error;
} }