iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: fieldbus: make controller_class constant

Browse Source 
Now that the driver core allows for struct class to be in read-only
memory, making all 'class' structures to be declared at build time
placing them into read-only memory, instead of having to be dynamically
allocated at load time.

Cc: Sven Van Asbroeck <TheSven73@gmail.com>
Link: https://lore.kernel.org/r/2023100552-entrench-dingbat-093a@gregkh
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman
2023-10-05 15:43:53 +02:00
parent 06d0b81188
commit 9565794b1b
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/staging/fieldbus/anybuss/arcx-anybus.c
View File

@@ -218,7 +218,10 @@ static const struct regulator_desc can_power_desc = {
.ops = &can_power_ops, .ops = &can_power_ops,
}; };
static struct class *controller_class; static const struct class controller_class = {
.name = "arcx_anybus_controller",
};
static DEFINE_IDA(controller_index_ida); static DEFINE_IDA(controller_index_ida);
static int controller_probe(struct platform_device *pdev) static int controller_probe(struct platform_device *pdev)
@@ -301,7 +304,7 @@ static int controller_probe(struct platform_device *pdev)
err = -ENOMEM; err = -ENOMEM;
goto out_ida; goto out_ida;
} }
cd->class_dev->class = controller_class; cd->class_dev->class = &controller_class;
cd->class_dev->groups = controller_attribute_groups; cd->class_dev->groups = controller_attribute_groups;
cd->class_dev->parent = dev; cd->class_dev->parent = dev;
cd->class_dev->id = id; cd->class_dev->id = id;
@@ -351,12 +354,12 @@ static int __init controller_init(void)
{ {
int err; int err;
controller_class = class_create("arcx_anybus_controller"); err = class_register(&controller_class);
if (IS_ERR(controller_class)) if (err)
return PTR_ERR(controller_class); return err;
err = platform_driver_register(&controller_driver); err = platform_driver_register(&controller_driver);
if (err) if (err)
class_destroy(controller_class); class_unregister(&controller_class);
return err; return err;
} }
@@ -364,7 +367,7 @@ static int __init controller_init(void)
static void __exit controller_exit(void) static void __exit controller_exit(void)
{ {
platform_driver_unregister(&controller_driver); platform_driver_unregister(&controller_driver);
class_destroy(controller_class); class_unregister(&controller_class);
ida_destroy(&controller_index_ida); ida_destroy(&controller_index_ida);
} }