iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: vt6655: Convert macro MACvReceive0 to function

Browse Source 
Convert macro to static function. Multiline macros are not liked by
kernel community. Rename variable dwData to reg_value to avoid
CamelCase which is not accepted by checkpatch.pl. Change variable
declaration to u32 as this improves readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/059aca149bd0c1d75df4fb3cd8a177aa4948fb02.1659080988.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Philipp Hortmann 2022-07-29 10:14:14 +02:00 committed by Greg Kroah-Hartman
parent 568035b01c
commit 9665eaf50a
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/vt6655/device_main.c
View File

@ -205,6 +205,17 @@ static void vt6655_mac_read_ether_addr(void __iomem *iobase, u8 *mac_addr)
iowrite8(0, iobase + MAC_REG_PAGE1SEL);
}
static void MACvReceive0(void __iomem *iobase)
{
u32 reg_value;
reg_value = ioread32(iobase + MAC_REG_RXDMACTL0);
if (reg_value & DMACTL_RUN)
iowrite32(DMACTL_WAKE, iobase + MAC_REG_RXDMACTL0);
else
iowrite32(DMACTL_RUN, iobase + MAC_REG_RXDMACTL0);
}
/*
* Initialisation of MAC & BBP registers
*/

10
drivers/staging/vt6655/mac.h
View File

@ -537,16 +537,6 @@
/*--------------------- Export Macros ------------------------------*/
#define MACvReceive0(iobase) \
do { \
unsigned long dwData; \
dwData = ioread32(iobase + MAC_REG_RXDMACTL0); \
if (dwData & DMACTL_RUN) \
iowrite32(DMACTL_WAKE, iobase + MAC_REG_RXDMACTL0); \
else \
iowrite32(DMACTL_RUN, iobase + MAC_REG_RXDMACTL0); \
} while (0)
#define MACvReceive1(iobase) \
do { \
unsigned long dwData; \