perf tests test_task_analyzer: Fix shellcheck issues
Fixed the following shellcheck issues in test_task_analyzer.sh file: SC2086: Double quote to prevent globbing and word splitting warnings in shell-check. Fixes the following shellcheck issues, SC2086: Double quote to prevent globbing and word splitting warnings in shell-check. Before Patch: $ shellcheck ./test_task_analyzer.sh | grep "SC2086" | ... In ./test_task_analyzer.sh line 13: SC2086: Double quote to prevent globbing and word splitting. In ./test_task_analyzer.sh line 24: SC2086: Double quote to prevent globbing and word splitting. In ./test_task_analyzer.sh line 39: SC2086: Double quote to prevent globbing and word splitting. After Patch: $ shellcheck ./test_task_analyzer.sh | grep -i "SC2086" None perf test result after patch: PASS: "test_basic" PASS: "test_ns_rename" PASS: "test_ms_filtertasks_highlight" PASS: "test_extended_times_timelimit_limittasks" PASS: "test_summary" PASS: "test_summaryextended" PASS: "test_summaryonly" PASS: "test_extended_times_summary_ns" PASS: "test_extended_times_summary_ns" PASS: "test_csv" PASS: "test_csvsummary" PASS: "test_csv_extended_times" PASS: "test_csvsummary_extended" Signed-off-by: Aboorva Devarajan <aboorvad@linux.vnet.ibm.com> Cc: Disha Goel <disgoel@linux.vnet.ibm.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: John Garry <john.g.garry@oracle.com> Cc: Madhavan Srinivasan <maddy@linux.ibm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: linuxppc-dev@lists.ozlabs.org Link: https://lore.kernel.org/r/20230613164145.50488-10-atrajeev@linux.vnet.ibm.com Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Signed-off-by: Kajol Jain <kjain@linux.ibm.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Aboorva Devarajan
Arnaldo Carvalho de Melo
parent
a6bdb815ad
commit
9694dfe0a3
@ -10,7 +10,7 @@ cleanup() {
|
||||
rm -f perf.data.old
|
||||
rm -f csv
|
||||
rm -f csvsummary
|
||||
rm -rf $tmpdir
|
||||
rm -rf "$tmpdir"
|
||||
trap - exit term int
|
||||
}
|
||||
|
||||
@ -21,7 +21,7 @@ trap_cleanup() {
|
||||
trap trap_cleanup exit term int
|
||||
|
||||
report() {
|
||||
if [ $1 = 0 ]; then
|
||||
if [ "$1" = 0 ]; then
|
||||
echo "PASS: \"$2\""
|
||||
else
|
||||
echo "FAIL: \"$2\" Error message: \"$3\""
|
||||
@ -36,11 +36,11 @@ check_exec_0() {
|
||||
}
|
||||
|
||||
find_str_or_fail() {
|
||||
grep -q "$1" $2
|
||||
if [ $? != 0 ]; then
|
||||
report 1 $3 "Failed to find required string:'${1}'."
|
||||
grep -q "$1" "$2"
|
||||
if [ "$?" != 0 ]; then
|
||||
report 1 "$3" "Failed to find required string:'${1}'."
|
||||
else
|
||||
report 0 $3
|
||||
report 0 "$3"
|
||||
fi
|
||||
}
|
||||
|
||||
@ -52,86 +52,86 @@ prepare_perf_data() {
|
||||
# check standard inkvokation with no arguments
|
||||
test_basic() {
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer > $out
|
||||
perf script report task-analyzer > "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Comm" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Comm" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_ns_rename(){
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer --ns --rename-comms-by-tids 0:random > $out
|
||||
perf script report task-analyzer --ns --rename-comms-by-tids 0:random > "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Comm" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Comm" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_ms_filtertasks_highlight(){
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer --ms --filter-tasks perf --highlight-tasks perf \
|
||||
> $out
|
||||
> "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Comm" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Comm" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_extended_times_timelimit_limittasks() {
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer --extended-times --time-limit :99999 \
|
||||
--limit-to-tasks perf > $out
|
||||
--limit-to-tasks perf > "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Out-Out" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Out-Out" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_summary() {
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer --summary > $out
|
||||
perf script report task-analyzer --summary > "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Summary" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Summary" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_summaryextended() {
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer --summary-extended > $out
|
||||
perf script report task-analyzer --summary-extended > "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Inter Task Times" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Inter Task Times" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_summaryonly() {
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer --summary-only > $out
|
||||
perf script report task-analyzer --summary-only > "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Summary" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Summary" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_extended_times_summary_ns() {
|
||||
out="$tmpdir/perf.out"
|
||||
perf script report task-analyzer --extended-times --summary --ns > $out
|
||||
perf script report task-analyzer --extended-times --summary --ns > "$out"
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Out-Out" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Summary" $out ${FUNCNAME[0]}
|
||||
find_str_or_fail "Out-Out" "$out" "${FUNCNAME[0]}"
|
||||
find_str_or_fail "Summary" "$out" "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_csv() {
|
||||
perf script report task-analyzer --csv csv > /dev/null
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Comm;" csv ${FUNCNAME[0]}
|
||||
find_str_or_fail "Comm;" csv "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_csv_extended_times() {
|
||||
perf script report task-analyzer --csv csv --extended-times > /dev/null
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Out-Out;" csv ${FUNCNAME[0]}
|
||||
find_str_or_fail "Out-Out;" csv "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_csvsummary() {
|
||||
perf script report task-analyzer --csv-summary csvsummary > /dev/null
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Comm;" csvsummary ${FUNCNAME[0]}
|
||||
find_str_or_fail "Comm;" csvsummary "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
test_csvsummary_extended() {
|
||||
perf script report task-analyzer --csv-summary csvsummary --summary-extended \
|
||||
>/dev/null
|
||||
check_exec_0 "perf"
|
||||
find_str_or_fail "Out-Out;" csvsummary ${FUNCNAME[0]}
|
||||
find_str_or_fail "Out-Out;" csvsummary "${FUNCNAME[0]}"
|
||||
}
|
||||
|
||||
prepare_perf_data
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user