iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hwrng: core - Use DEVICE_ATTR_<RW|RO> macro

Browse Source 
Use DEVICE_ATTR_RW()/DEVICE_ATTR_RO() helper instead of
plain DEVICE_ATTR, which makes the code a bit shorter and
easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
YueHaibing 2021-05-20 21:57:13 +08:00 committed by Herbert Xu
parent aa22cd7f67
commit 98f481f22d
1 changed files with 15 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/char/hw_random/core.c
View File

@ -319,7 +319,7 @@ static int enable_best_rng(void)
return ret; return ret;
} }
static ssize_t hwrng_attr_current_store(struct device *dev, static ssize_t rng_current_store(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
const char *buf, size_t len) const char *buf, size_t len)
{ {
@ -354,7 +354,7 @@ static ssize_t hwrng_attr_current_store(struct device *dev,
return err ? : len; return err ? : len;
} }
static ssize_t hwrng_attr_current_show(struct device *dev, static ssize_t rng_current_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
@ -371,7 +371,7 @@ static ssize_t hwrng_attr_current_show(struct device *dev,
return ret; return ret;
} }
static ssize_t hwrng_attr_available_show(struct device *dev, static ssize_t rng_available_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
@ -392,22 +392,16 @@ static ssize_t hwrng_attr_available_show(struct device *dev,
return strlen(buf); return strlen(buf);
} }
static ssize_t hwrng_attr_selected_show(struct device *dev, static ssize_t rng_selected_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
return sysfs_emit(buf, "%d\n", cur_rng_set_by_user); return sysfs_emit(buf, "%d\n", cur_rng_set_by_user);
} }
static DEVICE_ATTR(rng_current, S_IRUGO | S_IWUSR, static DEVICE_ATTR_RW(rng_current);
hwrng_attr_current_show, static DEVICE_ATTR_RO(rng_available);
hwrng_attr_current_store); static DEVICE_ATTR_RO(rng_selected);
static DEVICE_ATTR(rng_available, S_IRUGO,
hwrng_attr_available_show,
NULL);
static DEVICE_ATTR(rng_selected, S_IRUGO,
hwrng_attr_selected_show,
NULL);
static struct attribute *rng_dev_attrs[] = { static struct attribute *rng_dev_attrs[] = {
&dev_attr_rng_current.attr, &dev_attr_rng_current.attr,