iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HID: hiddev: Return specific error codes on connect failure

Browse Source 
The only caller of this function only cares about gross success/failure
but we still might as well resolve the following smatch warning and fix
the other error paths as well:

    hiddev.c:894 hiddev_connect() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Jason Gerecke 2021-02-11 11:30:59 -08:00 committed by Jiri Kosina
parent 69aea9d284
commit 9951bb259d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/hid/usbhid/hiddev.c
View File

@ -887,11 +887,11 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
break; break;
if (i == hid->maxcollection) if (i == hid->maxcollection)
return -1; return -EINVAL;
} }
if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL))) if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
return -1; return -ENOMEM;
init_waitqueue_head(&hiddev->wait); init_waitqueue_head(&hiddev->wait);
INIT_LIST_HEAD(&hiddev->list); INIT_LIST_HEAD(&hiddev->list);
@ -905,7 +905,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
hid_err(hid, "Not able to get a minor for this device\n"); hid_err(hid, "Not able to get a minor for this device\n");
hid->hiddev = NULL; hid->hiddev = NULL;
kfree(hiddev); kfree(hiddev);
return -1; return retval;
} }
/* /*